From: dsc <dsc@wikimedia.org>
Date: Tue, 8 May 2012 17:07:09 +0000 (-0700)
Subject: checkpoint
X-Git-Url: http://git.less.ly:3516/?a=commitdiff_plain;h=30b1d4b28b208e13b99c6ce343873c461cda5a41;p=limn.git

checkpoint
---

diff --git a/lib/dataset/dataset-model.co b/lib/dataset/dataset-model.co
index 44e3a4c..c797e44 100644
--- a/lib/dataset/dataset-model.co
+++ b/lib/dataset/dataset-model.co
@@ -73,8 +73,12 @@ DataSet = exports.DataSet = BaseModel.extend do # {{{
     #     this
     
     /**
-     * Override to handle the case where one of our rich sub-objects is attempted
-     * to be overridden with a native object.
+     * Override to handle the case where one of our rich sub-objects 
+     * (basically `metrics`) is set as a result of the `fetch()` call by the
+     * Graph object. To prevent it from blowing away the `MetricList`, we
+     * perform a `reset()` here. But that won't trigger a `change:metrics` event,
+     * so we do a little dance to set it twice, as object identity would otherwise
+     * cause it to think nothing has changed.
      */
     set: (key, value, opts) ->
         # return DataSet.__super__.set ... unless @metrics